Skip to content

refactor: extract dereference/validate pipeline from reconcile#968

Merged
maltesander merged 13 commits into
mainfrom
feat/dereference-validate-steps
Jun 1, 2026
Merged

refactor: extract dereference/validate pipeline from reconcile#968
maltesander merged 13 commits into
mainfrom
feat/dereference-validate-steps

Conversation

@maltesander

@maltesander maltesander commented May 19, 2026 •
edited by adwk67
Loading

Copy link
Copy Markdown
Member

Description

  • added dereference and validate steps

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this May 19, 2026
@maltesander maltesander mentioned this pull request May 19, 2026
Closed
16 tasks
@adwk67 adwk67 self-requested a review May 22, 2026 14:05
@adwk67 adwk67 moved this to Development: In Review in Stackable Engineering May 22, 2026
adwk67
adwk67 reviewed May 22, 2026
View reviewed changes

@adwk67 adwk67 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need a similar set of asserts for smoke-kafkakraft tests as well.

Comment thread rust/operator-binary/src/controller/dereference.rs Outdated
Comment thread rust/operator-binary/src/controller/validate.rs Outdated
Comment thread rust/operator-binary/src/controller.rs Outdated
Comment thread rust/operator-binary/src/controller/validate.rs Outdated
@maltesander maltesander requested a review from adwk67 May 27, 2026 12:34
adwk67
adwk67 reviewed Jun 1, 2026
View reviewed changes
Comment thread rust/operator-binary/src/controller/validate.rs Outdated
maltesander and others added 2 commits June 1, 2026 10:58
@maltesander @adwk67
Update rust/operator-binary/src/controller/validate.rs
7a82515 
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
@maltesander
Merge remote-tracking branch 'origin/main' into feat/dereference-vali…
99c2c51 
…date-steps
adwk67
adwk67 approved these changes Jun 1, 2026
View reviewed changes

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I've only run the smoke tests to verify)

@maltesander maltesander added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 0d2661f Jun 1, 2026
12 checks passed
@maltesander maltesander deleted the feat/dereference-validate-steps branch June 1, 2026 10:15
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jun 1, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@maltesander maltesander

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maltesander @adwk67 @lfrancke